Skip to content

gh30 push write wrong rev#31

Merged
BenjiMilan merged 10 commits intodevelopfrom
feature/gh30_push_write_wrong_rev
Mar 2, 2026
Merged

gh30 push write wrong rev#31
BenjiMilan merged 10 commits intodevelopfrom
feature/gh30_push_write_wrong_rev

Conversation

@BenjiMilan
Copy link
Contributor

@BenjiMilan BenjiMilan commented Feb 13, 2026 •
edited
Loading

This should have been a couple of PRs but is now all in one. The things changed are:

  • Finish auto resolves manifests with only changes to revisions.
  • Push checks out branch on all projects instead of switching manifest.
  • Finish stops spamming messages to change merge commit messages.
  • Start checks correctly for existing remote branch existing.
  • Some other more general changes.

@BenjiMilan BenjiMilan requested a review from TB-1993 February 13, 2026 09:57
@BenjiMilan BenjiMilan self-assigned this Feb 13, 2026
Copilot AI review requested due to automatic review settings February 13, 2026 09:57
Copilot AI reviewed Feb 13, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses issue #30 where running sc master push while on the develop branch would incorrectly write develop branch revisions to the master manifest. The fix changes the revision retrieval logic to explicitly reference the target branch's commit hash rather than using the currently checked-out commit.

Changes:

  • Modified _update_manifest_revisions to use branch-specific commit hashes instead of the current HEAD commit
  • Added tag pushing to the manifest repository push operation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 23, 2026 15:00
Copilot AI reviewed Feb 23, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BenjiMilan BenjiMilan force-pushed the feature/gh30_push_write_wrong_rev branch from 468e93e to e24af0d Compare February 23, 2026 17:18
Copilot AI review requested due to automatic review settings February 23, 2026 17:18
Copilot AI reviewed Feb 23, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@TB-1993 TB-1993 linked an issue Feb 24, 2026 that may be closed by this pull request
Bug: Sc push uses wrong revisions if pushing from a different branch. #30
Closed
Copilot AI review requested due to automatic review settings February 26, 2026 13:51
Copilot AI reviewed Feb 26, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BenjiMilan BenjiMilan force-pushed the feature/gh30_push_write_wrong_rev branch from ff75502 to 034c99d Compare February 28, 2026 09:05
Copilot AI review requested due to automatic review settings March 2, 2026 10:14
Copilot AI reviewed Mar 2, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

TB-1993
TB-1993 previously approved these changes Mar 2, 2026
View reviewed changes
Copy link

@TB-1993 TB-1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix a couple of the copilot issues then ship it!

TB-1993
TB-1993 approved these changes Mar 2, 2026
View reviewed changes
Copy link

@TB-1993 TB-1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@BenjiMilan BenjiMilan merged commit 893b927 into develop Mar 2, 2026
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2026
@BenjiMilan BenjiMilan deleted the feature/gh30_push_write_wrong_rev branch March 2, 2026 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@TB-1993 TB-1993 TB-1993 approved these changes

Assignees

@BenjiMilan BenjiMilan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Sc push uses wrong revisions if pushing from a different branch.

3 participants

@BenjiMilan @TB-1993